commit: d10bd72a993057c7faab0c49fdc852444da9ef09 Author: Ulrich Müller <ulm <AT> gentoo <DOT> org> AuthorDate: Sat Jan 14 19:04:53 2023 +0000 Commit: Arthur Zamarin <arthurzam <AT> gentoo <DOT> org> CommitDate: Sat Jan 14 20:30:58 2023 +0000 URL: https://gitweb.gentoo.org/proj/pkgcore/pkgcheck.git/commit/?id=d10bd72a
VariableScopeCheck: Disallow D and ED in pkg_postinst According to QA policy PG 107: https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0107 (Note that "pkg_postinst" was misspelt as "pkg_postint", so it would have warned already.) Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org> Closes: https://github.com/pkgcore/pkgcheck/pull/523 Closes: https://github.com/pkgcore/pkgcheck/issues/516 Signed-off-by: Arthur Zamarin <arthurzam <AT> gentoo.org> src/pkgcheck/checks/codingstyle.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pkgcheck/checks/codingstyle.py b/src/pkgcheck/checks/codingstyle.py index ea315259..2145e2de 100644 --- a/src/pkgcheck/checks/codingstyle.py +++ b/src/pkgcheck/checks/codingstyle.py @@ -966,8 +966,8 @@ class VariableScopeCheck(Check): "SYSROOT": ("src_", "pkg_setup"), "ESYSROOT": ("src_", "pkg_setup"), "BROOT": ("src_", "pkg_setup"), - "D": ("src_install", "pkg_preinst", "pkg_postint"), - "ED": ("src_install", "pkg_preinst", "pkg_postint"), + "D": ("src_install", "pkg_preinst"), + "ED": ("src_install", "pkg_preinst"), "DESTTREE": "src_install", "INSDESTTREE": "src_install", "MERGE_TYPE": "pkg_",
