commit:     ff83b5e28ffaf5cb62afed4888968a11f277e49f
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun May  7 15:31:34 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun May  7 15:59:19 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff83b5e2

flag-o-matic.eclass: drop -fstack-check from ALLOWED_FLAGS (strip-flags 
whitelist)

-fstack-check is _not_ a safe flag:
* 
https://developers.redhat.com/blog/2017/09/25/stack-clash-mitigation-gcc-background
* 
https://developers.redhat.com/blog/2019/04/30/stack-clash-mitigation-in-gcc-why-fstack-check-is-not-the-answer

Nobody is really interested in maintaining this functionality upstream in GCC
anymore for this reason, it's not IIRC supported in Clang, and we're not testing
it either.

Please use the far superior -fstack-clash-protection instead.

Signed-off-by: Sam James <sam <AT> gentoo.org>

 eclass/flag-o-matic.eclass | 1 -
 1 file changed, 1 deletion(-)

diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
index 3dd39c54a531..be169f934c02 100644
--- a/eclass/flag-o-matic.eclass
+++ b/eclass/flag-o-matic.eclass
@@ -51,7 +51,6 @@ _setup-allowed-flags() {
 
                # Hardening flags
                '-fstack-protector*'
-               '-fstack-check*' -fno-stack-check
                -fstack-clash-protection
                '-fcf-protection=*'
                -fbounds-check -fbounds-checking

Reply via email to