commit:     a327dcfb96db1aba2499bdf8d84a298fa815adc5
Author:     Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
AuthorDate: Wed Aug  2 10:42:32 2023 +0000
Commit:     Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
CommitDate: Wed Aug  2 11:22:10 2023 +0000
URL:        
https://gitweb.gentoo.org/proj/pkgcore/pkgcheck.git/commit/?id=a327dcfb

VariableScopeCheck: Disallow D and ED in pkg_postinst (again)

https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0107

Fixes: 2cfc92ccab6ddfedd79ec16b8ebdde4eae8d2ad4
Signed-off-by: Arthur Zamarin <arthurzam <AT> gentoo.org>

 src/pkgcheck/checks/codingstyle.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pkgcheck/checks/codingstyle.py 
b/src/pkgcheck/checks/codingstyle.py
index a05831cd..2b7dbafe 100644
--- a/src/pkgcheck/checks/codingstyle.py
+++ b/src/pkgcheck/checks/codingstyle.py
@@ -987,8 +987,8 @@ class VariableScopeCheck(Check):
             "SYSROOT": ("src_", "pkg_setup"),
             "ESYSROOT": ("src_", "pkg_setup"),
             "BROOT": ("src_", "pkg_setup"),
-            "D": ("src_install", "pkg_preinst", "pkg_postinst"),
-            "ED": ("src_install", "pkg_preinst", "pkg_postinst"),
+            "D": ("src_install", "pkg_preinst"),  # pkg_postinst is forbidden 
by QA policy PG 107
+            "ED": ("src_install", "pkg_preinst"),  # pkg_postinst is forbidden 
by QA policy PG 107
             "DESTTREE": "src_install",
             "INSDESTTREE": "src_install",
             "MERGE_TYPE": "pkg_",

Reply via email to