[gentoo-commits] repo/gentoo:master commit in: dev-qt/qtbase/

[Ionen Wolkens]

commit:     3b88166e6621a80c6ea344585dc56f203bba1a7a
Author:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Mon Dec 18 01:28:50 2023 +0000
Commit:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Mon Dec 18 01:36:17 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b88166e

dev-qt/qtbase: extend testlib comment a bit

Just to clarify that this was an issue when not building tests too.

Primary reason this been made default was because some other dev-qt
packages (qtdeclarative I recall?) failed even with USE=-test and
did not felt worth working around nor have a IUSE=+testlib (saves
the need to declare it for tests on a whole lot of packages too).

Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>

 dev-qt/qtbase/qtbase-6.5.3-r1.ebuild | 3 ++-
 dev-qt/qtbase/qtbase-6.6.1-r1.ebuild | 3 ++-
 dev-qt/qtbase/qtbase-6.6.9999.ebuild | 3 ++-
 dev-qt/qtbase/qtbase-6.7.9999.ebuild | 3 ++-
 dev-qt/qtbase/qtbase-6.9999.ebuild   | 3 ++-
 5 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/dev-qt/qtbase/qtbase-6.5.3-r1.ebuild 
b/dev-qt/qtbase/qtbase-6.5.3-r1.ebuild
index ce2ea30fc9f3..8c60fe9a49b6 100644
--- a/dev-qt/qtbase/qtbase-6.5.3-r1.ebuild
+++ b/dev-qt/qtbase/qtbase-6.5.3-r1.ebuild
@@ -185,7 +185,8 @@ src_configure() {
                $(qt_feature gui)
                $(qt_feature network)
                $(qt_feature sql)
-               -DQT_FEATURE_testlib=ON # trivial and often needed to build 
revdeps
+               # trivial, and is often needed (sometimes even when not 
building tests)
+               -DQT_FEATURE_testlib=ON
                $(qt_feature xml)
        )
 

diff --git a/dev-qt/qtbase/qtbase-6.6.1-r1.ebuild 
b/dev-qt/qtbase/qtbase-6.6.1-r1.ebuild
index 4e879f6996d9..e6a2b849eb51 100644
--- a/dev-qt/qtbase/qtbase-6.6.1-r1.ebuild
+++ b/dev-qt/qtbase/qtbase-6.6.1-r1.ebuild
@@ -184,7 +184,8 @@ src_configure() {
                $(qt_feature gui)
                $(qt_feature network)
                $(qt_feature sql)
-               -DQT_FEATURE_testlib=ON # trivial and often needed to build 
revdeps
+               # trivial, and is often needed (sometimes even when not 
building tests)
+               -DQT_FEATURE_testlib=ON
                $(qt_feature xml)
        )
 

diff --git a/dev-qt/qtbase/qtbase-6.6.9999.ebuild 
b/dev-qt/qtbase/qtbase-6.6.9999.ebuild
index f3b43daedeae..e0e435925cbc 100644
--- a/dev-qt/qtbase/qtbase-6.6.9999.ebuild
+++ b/dev-qt/qtbase/qtbase-6.6.9999.ebuild
@@ -184,7 +184,8 @@ src_configure() {
                $(qt_feature gui)
                $(qt_feature network)
                $(qt_feature sql)
-               -DQT_FEATURE_testlib=ON # trivial and often needed to build 
revdeps
+               # trivial, and is often needed (sometimes even when not 
building tests)
+               -DQT_FEATURE_testlib=ON
                $(qt_feature xml)
        )
 

diff --git a/dev-qt/qtbase/qtbase-6.7.9999.ebuild 
b/dev-qt/qtbase/qtbase-6.7.9999.ebuild
index 4f56473ee60f..2056d447ada9 100644
--- a/dev-qt/qtbase/qtbase-6.7.9999.ebuild
+++ b/dev-qt/qtbase/qtbase-6.7.9999.ebuild
@@ -185,7 +185,8 @@ src_configure() {
                $(qt_feature gui)
                $(qt_feature network)
                $(qt_feature sql)
-               -DQT_FEATURE_testlib=ON # trivial and often needed to build 
revdeps
+               # trivial, and is often needed (sometimes even when not 
building tests)
+               -DQT_FEATURE_testlib=ON
                $(qt_feature xml)
        )
 

diff --git a/dev-qt/qtbase/qtbase-6.9999.ebuild 
b/dev-qt/qtbase/qtbase-6.9999.ebuild
index 4f56473ee60f..2056d447ada9 100644
--- a/dev-qt/qtbase/qtbase-6.9999.ebuild
+++ b/dev-qt/qtbase/qtbase-6.9999.ebuild
@@ -185,7 +185,8 @@ src_configure() {
                $(qt_feature gui)
                $(qt_feature network)
                $(qt_feature sql)
-               -DQT_FEATURE_testlib=ON # trivial and often needed to build 
revdeps
+               # trivial, and is often needed (sometimes even when not 
building tests)
+               -DQT_FEATURE_testlib=ON
                $(qt_feature xml)
        )