commit: bd56bfe0365680f36c3b03221e9f3ea93404f9e1 Author: Alexey Sokolov <alexey+gentoo <AT> asokolov <DOT> org> AuthorDate: Fri Feb 23 09:14:11 2024 +0000 Commit: Joonas Niilola <juippis <AT> gentoo <DOT> org> CommitDate: Fri Feb 23 13:03:42 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd56bfe0
net-irc/kvirc: fix build with +dcc-video Closes: https://bugs.gentoo.org/925309 Signed-off-by: Alexey Sokolov <alexey+gentoo <AT> asokolov.org> Signed-off-by: Joonas Niilola <juippis <AT> gentoo.org> net-irc/kvirc/files/kvirc-5.2.0-dccvideo.patch | 69 ++++++++++++++++++++++++++ net-irc/kvirc/kvirc-5.2.0-r2.ebuild | 1 + 2 files changed, 70 insertions(+) diff --git a/net-irc/kvirc/files/kvirc-5.2.0-dccvideo.patch b/net-irc/kvirc/files/kvirc-5.2.0-dccvideo.patch new file mode 100644 index 000000000000..0d2944e30830 --- /dev/null +++ b/net-irc/kvirc/files/kvirc-5.2.0-dccvideo.patch @@ -0,0 +1,69 @@ +From da4659a9d9c30b6d89875f328cca88758ef568c6 Mon Sep 17 00:00:00 2001 +From: Aleksei Bavshin <alebast...@gmail.com> +Date: Wed, 17 Jan 2024 20:58:27 -0800 +Subject: [PATCH] Fix build with Qt5 and WANT_DCC_VIDEO +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +``` +src/modules/dcc/DccVideoWindow.cpp: In member function ‘virtual const QString& DccVideoWindow::target()’: +src/modules/dcc/DccVideoWindow.cpp:660:40: error: cannot convert ‘QString’ to ‘QString*’ in assignment +``` +--- + src/modules/dcc/DccVideoWindow.cpp | 14 ++------------ + src/modules/dcc/DccVideoWindow.h | 2 +- + 2 files changed, 3 insertions(+), 13 deletions(-) + +diff --git a/src/modules/dcc/DccVideoWindow.cpp b/src/modules/dcc/DccVideoWindow.cpp +index 7f4f66ea42..7cf8058fe8 100644 +--- a/src/modules/dcc/DccVideoWindow.cpp ++++ b/src/modules/dcc/DccVideoWindow.cpp +@@ -396,7 +396,6 @@ DccVideoWindow::DccVideoWindow(DccDescriptor * dcc, const char * name) + { + m_pDescriptor = dcc; + m_pSlaveThread = nullptr; +- m_pszTarget = nullptr; + + m_pButtonBox = new KviTalHBox(this); + +@@ -557,12 +556,6 @@ DccVideoWindow::~DccVideoWindow() + } + + KviThreadManager::killPendingEvents(this); +- +- if(m_pszTarget) +- { +- delete m_pszTarget; +- m_pszTarget = nullptr; +- } + } + + void DccVideoWindow::resizeEvent(QResizeEvent *) +@@ -654,11 +647,8 @@ void DccVideoWindow::connectionInProgress() + const QString & DccVideoWindow::target() + { + // This may change on the fly... +- if(!m_pszTarget) +- m_pszTarget = new QString(); +- +- m_pszTarget = QString::asprintf("%s@%s:%s", m_pDescriptor->szNick.toUtf8().data(), m_pDescriptor->szIp.toUtf8().data(), m_pDescriptor->szPort.toUtf8().data()); +- return *m_pszTarget; ++ m_szTarget = QString::asprintf("%s@%s:%s", m_pDescriptor->szNick.toUtf8().data(), m_pDescriptor->szIp.toUtf8().data(), m_pDescriptor->szPort.toUtf8().data()); ++ return m_szTarget; + } + + void DccVideoWindow::getBaseLogFileName(QString & buffer) +diff --git a/src/modules/dcc/DccVideoWindow.h b/src/modules/dcc/DccVideoWindow.h +index 98bb622f5b..d0f957ea3e 100644 +--- a/src/modules/dcc/DccVideoWindow.h ++++ b/src/modules/dcc/DccVideoWindow.h +@@ -129,7 +129,7 @@ class DccVideoWindow : public DccWindow + QGridLayout * m_pLayout; + QTimer m_Timer; + QLabel * m_pVideoLabel[3]; +- QString * m_pszTarget; ++ QString m_szTarget; + DccVideoThread * m_pSlaveThread; + QByteArray m_tmpTextDataOut; + QString m_szLocalNick; diff --git a/net-irc/kvirc/kvirc-5.2.0-r2.ebuild b/net-irc/kvirc/kvirc-5.2.0-r2.ebuild index 5cd2cd5f3b7a..bb2c098eb7b8 100644 --- a/net-irc/kvirc/kvirc-5.2.0-r2.ebuild +++ b/net-irc/kvirc/kvirc-5.2.0-r2.ebuild @@ -70,6 +70,7 @@ DOCS=() PATCHES=( "${FILESDIR}/kvirc-5.2.0-qtver.patch" + "${FILESDIR}/kvirc-5.2.0-dccvideo.patch" ) pkg_setup() {
