commit:     2e1a1763119efca3eaa26835bafdc664ca039b7d
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Fri Mar 15 02:53:10 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri Mar 15 02:53:10 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e1a1763

media-libs/lsp-plugins: backport LTO filtering

Bug: https://bugs.gentoo.org/875833
Closes: https://bugs.gentoo.org/874339
Signed-off-by: Sam James <sam <AT> gentoo.org>

 media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild | 11 +++++++++++
 media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild    | 11 +++++++++++
 media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild    | 11 +++++++++++
 3 files changed, 33 insertions(+)

diff --git a/media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild 
b/media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild
index dde3a257e761..cb0430405e9a 100644
--- a/media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild
+++ b/media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild
@@ -59,6 +59,17 @@ PATCHES=(
 )
 
 src_configure() {
+       # -Werror=odr
+       # https://bugs.gentoo.org/875833
+       #
+       # Actually the whole thing is kind of a waste of time. It looks like
+       # programs use LDFLAGS, but libraries do not! So some things don't
+       # build with LTO, while other things don't build when LTO is enabled.
+       # Attempting to build with LTO is just a waste of time and cycles.
+       #
+       # This was reported upstream but the ticket closed. Abandon hope.
+       filter-lto
+
        use doc && MODULES+="doc"
        use jack && MODULES+=" jack"
        use ladspa && MODULES+=" ladspa"

diff --git a/media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild 
b/media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild
index f8d5a15f29c2..564fb4512fb9 100644
--- a/media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild
+++ b/media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild
@@ -55,6 +55,17 @@ DEPEND="
 RDEPEND="${DEPEND}"
 
 src_configure() {
+       # -Werror=odr
+       # https://bugs.gentoo.org/875833
+       #
+       # Actually the whole thing is kind of a waste of time. It looks like
+       # programs use LDFLAGS, but libraries do not! So some things don't
+       # build with LTO, while other things don't build when LTO is enabled.
+       # Attempting to build with LTO is just a waste of time and cycles.
+       #
+       # This was reported upstream but the ticket closed. Abandon hope.
+       filter-lto
+
        use doc && MODULES+="doc"
        use jack && MODULES+=" jack"
        use ladspa && MODULES+=" ladspa"

diff --git a/media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild 
b/media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild
index f8d5a15f29c2..564fb4512fb9 100644
--- a/media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild
+++ b/media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild
@@ -55,6 +55,17 @@ DEPEND="
 RDEPEND="${DEPEND}"
 
 src_configure() {
+       # -Werror=odr
+       # https://bugs.gentoo.org/875833
+       #
+       # Actually the whole thing is kind of a waste of time. It looks like
+       # programs use LDFLAGS, but libraries do not! So some things don't
+       # build with LTO, while other things don't build when LTO is enabled.
+       # Attempting to build with LTO is just a waste of time and cycles.
+       #
+       # This was reported upstream but the ticket closed. Abandon hope.
+       filter-lto
+
        use doc && MODULES+="doc"
        use jack && MODULES+=" jack"
        use ladspa && MODULES+=" ladspa"

Reply via email to