Hi all, base.eclass (which inherited by many other eclasses) has an src_unpack supporting patching from patchfiles listed in $PATCHES. However, today, if patching fails the process doesn't abort. So I propose:
==================
--- base.eclass 11 Jul 2005 15:08:06 -0000 1.27
+++ base.eclass 29 Jul 2005 13:45:39 -0000
@@ -35,11 +35,11 @@ base_src_unpack() {
cd ${S}
for x in $PATCHES; do
debug-print "$FUNCNAME: autopatch: patching
from ${x}"
- patch -p0 < ${x}
+ patch -p0 < ${x} || die "Patchfile $x failed
to apply"
done
for x in $PATCHES1; do
debug-print "$FUNCNAME: autopatch: patching
-p1 from ${x}"
- patch -p1 < ${x}
+ patch -p1 < ${x} || die "Patchfile $x failed
to apply"
done
;;
all)
====================
This will make some ebuilds fail which accidentally rely on non-applying
patches, which is the correct thing to do IMHO. Objections?
--
Dan Armak
Gentoo Linux developer (KDE)
Public GPG key: http://dev.gentoo.org/~danarmak/danarmak-gpg-public.key
Fingerprint: DD70 DBF9 E3D4 6CB9 2FDD 0069 508D 9143 8D5F 8951
pgp3JxWxcL9Pi.pgp
Description: PGP signature
