On Wed, Jul 30, 2025 at 08:43:07AM +0100, Sam James wrote:
> "Volkmar W. Pogatzki" <[email protected]> writes:
> 
> > Thanks to Yuan Liao <[email protected]> for providing this excellent
> > work. Copied from https://github.com/Leo3418/junit-5-ebuild-repo
> 
> Can you add a:
> a) Co-authored-by: ... line above your Signed-off-by for Yuan Liao?
> 2) Ask if they can provide a Signed-off-by we can use too? It would go
> above yours.

Sure!  You have my sign-off here, if this would work:

Signed-off-by: Yuan Liao <[email protected]>

> Not reviewed the eclass itself -- I don't expect to have comments
> though. I can try find time to look over it another time if needed.
> 
> >
> > Signed-off-by: Volkmar W. Pogatzki <[email protected]>
> > ---
> >  eclass/java-pkg-junit-5.eclass | 500 +++++++++++++++++++++++++++++++++
> >  1 file changed, 500 insertions(+)
> >  create mode 100755 eclass/java-pkg-junit-5.eclass
> >
> > diff --git a/eclass/java-pkg-junit-5.eclass b/eclass/java-pkg-junit-5.eclass
> > new file mode 100755
> > index 000000000000..cd3101f3eccd
> > --- /dev/null
> > +++ b/eclass/java-pkg-junit-5.eclass
> > @@ -0,0 +1,500 @@
> > +# Copyright 2022-2025 Gentoo Authors
> > +# Distributed under the terms of the GNU General Public License v2
> > +
> > +# @ECLASS: java-pkg-junit-5.eclass
> > +# @MAINTAINER:
> > +# Yuan Liao <[email protected]>
> 
> I imagine you want java@ here too.

I second this.

> > +# @AUTHOR:
> > +# Yuan Liao <[email protected]>
> > +# @SUPPORTED_EAPIS: 8
> 
> > [...]
> 
> sam

Thanks,
Leo3418

Attachment: signature.asc
Description: PGP signature

Reply via email to