-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Joshua Nichols wrote: > Patrick McLean wrote: >> There is a new version at >> http://dev.gentoo.org/~chutzpah/profile.bashrc that >> should fix all these possible problems. Thanks for pointing them out, > Around line 77, you have: > hasme ${flag} ${CFLAGS} ${CXXFLAGS} && trigger=1 && \ > ewarn "Your C(XX)FLAGS contain(s) \"${flag}\" which can break > packages." > > Might I suggest you change it to something like: > > if hasme ${flag} ${CFLAGS} ${CXXFLAGS}; then > trigger=1 > ewarn "Your C(XX)FLAGS contain(s) \"${flag}\" which can break > packages." > fi > Done.
> While there's nothing wrong with the original way, my suggestion would > make it a bit more obvious that you're setting the 'trigger' flag. > Readability is always a good thing :) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQFEP+cJWt/XSf2CZdkRAoGtAJ9e8CViKyluILpEH07J3i50ciuNnwCZAVu/ M94FKLlae7tyTRZ8TsE40zA= =XkHW -----END PGP SIGNATURE----- -- gentoo-dev@gentoo.org mailing list
