On Monday 01 October 2007, Ali Polatel wrote: > Mon, Oct 01, 2007 at 01:06:42AM -0700 tarihinde, Donnie Berkholz yazmış: > > On 07:46 Mon 01 Oct , Ali Polatel (hawking) wrote: > > > 1.1 sys-auth/pam_chroot/pam_chroot-0.9.2.ebuild > > > > > > file : > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-auth/pam_chroot/pam > > >_chroot-0.9.2.ebuild?rev=1.1&view=markup plain: > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-auth/pam_chroot/pam > > >_chroot-0.9.2.ebuild?rev=1.1&content-type=text/plain > > > > > > LDFLAGS="$(raw-ldflags)" emake \ > > > CC="$(tc-getCC)" LD="$(tc-getLD)" || die "emake failed" > > > > This reads really strangely to me. It's passing variables on both sides > > of emake. Generally one would just pick a side (afterwards) and add > > everything there. > > Well, here is the related part from Makefile: > > LDFLAGS := -x --shared $(LDFLAGS) > > emake LDFLAGS="$(raw-ldflags)" overrides that definition, > emake LDFLAGS="-x --shared $(raw-ldflags)" works as expected, or my > version, maybe I should add a note about it to the ebuild...
assuming they actually need to prepend here, you could get upstream to write it like so: override LDFLAGS := -x --shared $(LDFLAGS) if prepending is not needed, then this could work just as well: override LDFLAGS += -x --shared not sure how portable "override" is though ... -mike
signature.asc
Description: This is a digitally signed message part.
