Thomas Sachau yazmış:
> Ali Polatel (hawking) schrieb:
> >     use threads \
> >             && myconf="${myconf} --with-threads" \
> >             || myconf="${myconf} --without-threads"
> 
> What about an econf option $(use_with threads)?
> 
> >     econf \
> >             --with-fpectl \
> >             --enable-shared \
> >             `use_enable ipv6` \
> >             --infodir='${prefix}'/share/info \
> >             --mandir='${prefix}'/share/man \
> >             --with-libc='' \
> >             ${myconf} || die
> 
> "|| die" could be dropped
> 
> > src_install() {
> >     dodir /usr
> 
> Will the install fail without a /usr dir?
> 
> >     src_configure
> >     make DESTDIR="${D}" altinstall maninstall || die
> 
> Why not emake?
> 
> >     if use examples ; then
> >             mkdir -p "${D}"/usr/share/doc/${P}/examples
> >             cp -r "${S}"/Tools "${D}"/usr/share/doc/${P}/examples
> >     fi
> 
> what about this:
>       insinto /usr/share/doc/${P}/examples
>       doins -r Tools
> 
> >     python_mod_cleanup /usr/lib/python${PYVER}
> >     [[ "$(get_libdir)" == "lib" ]] || \
> >             python_mod_cleanup /usr/$(get_libdir)/python${PYVER}
> 
> Why not remove the first 2 lines?
> 
> >     python_mod_optimize -x "(site-packages|test)" \
> >                                             /usr/lib/python${PYVER}
> >     [[ "$(get_libdir)" == "lib" ]] || \
> >             python_mod_optimize -x "(site-packages|test)" \
> >                                                     
> > /usr/$(get_libdir)/python${PYVER}
> 
> the same here
> 
> 

+*python-2.6-r1 (06 Oct 2008)
+
+  06 Oct 2008; Ali Polatel <[EMAIL PROTECTED]> -python-2.6.ebuild,
+  +python-2.6-r1.ebuild:
+  Revbump. Use use_with for threads, remove die from econf, use emake
+  instead of make, remove redundant python_mod_{cleanup,optimize}. Drop old.
+

Thanks!

> -- 
> Thomas Sachau
> 
> Gentoo Linux Developer
> 

-- 
Regards,
Ali Polatel

Attachment: pgpefd2hJM87p.pgp
Description: PGP signature

Reply via email to