On Wed, 17 Feb 2010 18:11:42 +0000, Ciaran McCreesh
<[email protected]> wrote:
> On Wed, 17 Feb 2010 18:03:42 +0000
> Jeremy Olexa <[email protected]> wrote:
>> What is going on with all these undocumented changes? When I look at
>> the council logs to see what is in EAPI3, I don't see anything about
>> removing functions. This is just silly and wastes alot of people's
>> time for no practical gain.
>
> Being in eutils, none of this has anything to do with PMS or the
> Council.
So, I was highlighting a problem. No one wants to write docs, which is
quite bad for the health of Gentoo.
>
>> In my EAPI3 portage, bin/isolated-functions.sh still has eqawarn()
>> defined. So, what am I missing now?
>
> eqawarn has never been defined in any EAPI. It's a Portage internal,
> not something for ebuilds to use. If you'd like it to be in an EAPI, you
> can propose it for EAPI 5.
Yes, correct. For some reason, I thought it was valid to use eqawarn in
ebuilds. Now I guess a valid fix for eutils.eclass would be:
%% cvs di eutils.eclass
Index: eutils.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.333
diff -u -r1.333 eutils.eclass
--- eutils.eclass 17 Feb 2010 17:10:23 -0000 1.333
+++ eutils.eclass 17 Feb 2010 18:20:18 -0000
@@ -54,13 +54,11 @@
else
ebeep() {
- [[ $(type -t eqawarn) == function ]] && \
- eqawarn "QA Notice: ebeep is not defined in EAPI=3, please
file a bug at http://bugs.gentoo.org";
+ einfo "QA Notice: ebeep is not defined in EAPI=3, please
file a bug at http://bugs.gentoo.org";
}
epause() {
- [[ $(type -t eqawarn) == function ]] && \
- eqawarn "QA Notice: epause is not defined in EAPI=3,
please file a bug at http://bugs.gentoo.org";
+ einfo "QA Notice: epause is not defined in EAPI=3, please
file a bug at http://bugs.gentoo.org";
}
fi
(where einfo is used because it doesn't need to be logged)
-Jeremy
