On Saturday 07 August 2010 00:21:39 Markos Chandras (hwoarang) wrote:
> hwoarang 10/08/06 21:21:39
>
> Modified: ChangeLog
> Added: mlt-0.5.4-r1.ebuild
> Log:
> Respect {C,LD}FLAGS when building shared library. Bug #308873
> (Portage version: 2.2_rc67/cvs/Linux x86_64)
While fixing bugs can't be bad and I thank you for doing it, I can see a
couple of important quality problems in this commit:
- There is absolutely no reference to any patch sent upstream and I have not
seen anything on the upstream dev ml.
- If you are not in cc of the gentoo bug nor in the herd alias, please cc
yourself on the bug.
- Please close the bugs, even the dupes (and apply previous point to the dupes
too).
- That way you'll be able to quickly fix (apparently, I didn't check) obvious
mistakes [1].
- You'll have to do a rev. bump for *FLAGS respect, please also check if you
can avoid it by doing a version bump instead.
A.
[1] https://bugs.gentoo.org/show_bug.cgi?id=332523
