On Sunday 22 of August 2010 20:39:23 Michał Górny wrote: > Here goes the second revision. A short changelog: > > 83678d1 Export a default pkg_setup() and src_compile(). > 7f9b565 Introduce escons() function (similar to emake). > 19b7e14 Use underscores instead of dashes in function names. > > Attaching both the new rev and a diff against the first one.
I'd suggest providing all src_* phases except src_unpack. Even src_prepare that calls base_src_prepare - to get PATCHES and epatch_user support - for simplicity requiring EAPI-2 as providing src_unpack in buildsystem eclasses is a bad design (like providing src_prepare in scm eclasses - this one is yet to be fixed). Also calling base_src_install in scons_src_install if possible would be nice (DOCS, HTML_DOCS support) - to make it resemble cmake-utils, autotools-utils, and a bit of distutils, qt4-edge and gnome2 eclasses. -- regards MM
signature.asc
Description: This is a digitally signed message part.
