-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 W dniu 17.07.2011 10:45, Kfir Lavi pisze: > Hi, > I have created a new ebuild for net-misc/pimd [1]. > From the webpage: > pimd is a lightweight stand-alone PIM-SM v2 multicast routing daemon. > > I would like you guys to review the ebuild and the rc-file. > This ebuild is based on net-misc/mrouted.
> EAPI="2" Please use latest eapi when introducing new ebuilds > inherit eutils toolchain-funcs where do you use 'eutils.eclass'? > DESCRIPTION="Lightweight stand-alone PIM-SM v2 multicast routing daemon" > HOMEPAGE="http://vmlinux.org/jocke/pimd.shtml"; > SRC_URI="ftp://ftp.vmlinux.org/pub/People/jocke/${PN}/${P}.tar.bz2"; > LICENSE="Stanford" Is that a correct license? Compare LICENSE.mrouted with ${PORTDIR}/licenses/Stanford and then with BSD. > SLOT="0" > KEYWORDS="~amd64 ~x86" > IUSE="+doc" Where do you use doc flag? > DEPEND="|| ( dev-util/yacc sys-devel/bison )" > RDEPEND="" Is yacc or bison really invoked during build? (Check either Makefile or TODO ;) ) Assuming it isn't those two lines are unnecessary. > CONFIG_CHECK="~IP_PIMSM_V2:" > WARNING_BRIDGE="CONFIG_IP_PIMSM_V2 is required for pimd" these are not used. > src_prepare() { > # Respect user CFLAGS, remove upstream optimisation and -Werror > sed -i Makefile \ > -e '/^CFLAGS/{s|[[:space:]]=| +=|g;s|-O2||g;s|-Werror||g}' \ > || die > } It would be more legible if you convert it to patch. > src_compile() { > emake CC=$(tc-getCC) || die > } Some systems export CC as "gcc -m64". > src_install() { > dobin pimd || die ... All those helpers could be easily avoided. src_install() { emake DESTDIR="${D}" prefix=/usr \ datadir=/usr/share/doc/${PN} install || die newinitd "${FILESDIR}"/pimd.rc pimd } Only don't install unnecessary docs: sed -i -e "s/INSTALL LICENSE LICENSE.mrouted//" Makefile Please note that there's already bug for that pkg[1] it would be good if further development would be done there. Cheers, Kacper [1] https://bugs.gentoo.org/show_bug.cgi?id=352848 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iJwEAQECAAYFAk4irrgACgkQIiMqcbOVdxTfXAP/VAZi6HwGPRQrCzYTJ840brkb +KVBHUunzd+dML0m24oiq5CmR31SuYIpj4qXvsXuYYL2A2kK1N8R/A7KOcZ4MaGw BkltP/crrLJU6qHnTVrEXLE2SEYUxAGbTw2D4Lx0DE3jkLtikNDp/I2D0bS3aK9l /kuMMZp89zx293OeTBo= =QQI+ -----END PGP SIGNATURE-----
