On Thu, 18 Aug 2011 14:38:01 +0400 Maxim Koltsov <maksbo...@gentoo.org> wrote:
> We've fixed all the problems with eclass. Please review it and give OK
> for commit, i plan to do it this night.
> 0|1) die "EAPI not supported, bug ebuild mantainer" ;;
> *) die "Unknown EAPI, Bug eclass maintainers." ;;
I think I already mentioned that. Keep consistent case, and in this
case lowercase 'bug' is correct'.
> # @ECLASS-VARIABLE: LC_PCAT
> # @DESCRIPTION:
> # Set this to the category of the plugin, if any.
> : ${LC_PCAT:=}
Please use verbose variable names, and prefix them with eclass
filename; e.g. LEECHCRAFT_PLUGIN_CATEGORY.
And I think @DEFAULT_UNSET may be of interest too.
>
> if [ "${LC_PCAT+x}" != "x" ]; then
> CMAKE_USE_DIR="${S}/src/plugins/${LC_PCAT}/${PN#leechcraft-}"
> else
> if [[ ${PN} != "leechcraft-core" ]]; then
> CMAKE_USE_DIR="${S}/src/plugins/${PN#leechcraft-}"
> else
> CMAKE_USE_DIR="${S}/src"
> fi
> fi
if-elif-else-fi.
And I think you dropped gentoo-dev@ from recipients a few mails ago.
--
Best regards,
Michał Górny
signature.asc
Description: PGP signature
