>>>>> On Tue, 30 Aug 2011, Tomáš Chvátal wrote:
> See the attachment for the latest version :)
> # @FUNCTION: office-ext_get_implementation
> [...]
> for i in "${implementations[$@]}"; do
I think this should read "${implementations[@]}" instead, if the
intention is to loop over all array elements.
> # @FUNCTION: office-ext_remove_extension
> [...]
> ${UNOPKG_BINARY} remove --shared "${ext}" \
Not sure what unopkg accepts, but I guess you want to pass several
arguments here. So ${ext} shouldn't be quoted.
And why is the intermediate variable ext needed here, in the first
place? You could use "$@" directly (this time, with the quotes).
> # @FUNCTION: office-ext_src_install
> [...]
> # subshell to not polute rest of the env with the insinto redefinition
s/polute/pollute/
> for i in "${OO_EXTENSIONS[$@]}"; do
See above about $@.
> # @FUNCTION: office-ext_pkg_postinst
> [...]
> for i in "${OO_EXTENSIONS[$@]}"; do
Ditto.
> # @FUNCTION: office-ext_pkg_prerm
> [...]
> for i in "${OO_EXTENSIONS[$@]}"; do
Ditto.
Ulrich
