2011/10/12 Mike Frysinger <vap...@gentoo.org>:
> On Wednesday 12 October 2011 15:44:53 Alec Warner wrote:
>> If I want to add a patch to the list I might forget to to add the \
>
> admittedly, i hit this every once in a while, and with all the "|| die" being
> implicit, it doesn't get caught right away. fortunately latest portage will
> issue a QA warning at the end along the lines of "command not found:
> ${FILESDIR}/${P}-my-new.patch". so one can hope the maintainer tests their
> ebuilds and reviews QA output before committing ;).
> -mike
>
That is the reason for the patch array implemented in the base eclass
and why i want it in eapi5.
PATCHES=(
"patch1" # mycomment
"patch2" # another bug number
)
Example from wild:
PATCHES=(
"${FILESDIR}/${PN}-includes-libs-perl.patch"
"${FILESDIR}/${PN}-fix_wrong_linker_opts.patch"
"${FILESDIR}/${PN}-1.0.2-no_harfbuzz_tests.patxh"
)
See the typo on last patch.
>>> Preparing source in
>>> /var/tmp/portage/media-gfx/graphite2-1.0.3/work/graphite2-1.0.3 ...
* Applying graphite2-includes-libs-perl.patch ...
[ ok ]
* Applying graphite2-fix_wrong_linker_opts.patch ...
[ ok ]
* QA: File or directory
"/home/scarabeus/gentoo/gentoo-x86/media-gfx/graphite2/files/graphite2-1.0.2-no_harfbuzz_tests.patxh"
does not exist.
* QA: Check your PATCHES array or add missing file/directory.
* ERROR: media-gfx/graphite2-1.0.3 failed (prepare phase):
* Some patches failed. See above messages.
Which is why i really avoid calling epatch myself, the only reason is
to have conditional patches, which are root of all evil, because they
can be broken with update and you won't notice anyway.
Cheers
Tom
