On Friday 15 June 2012 03:44:14 Samuli Suominen wrote:
> On 06/13/2012 06:02 AM, Mike Frysinger wrote:
> > i've noticed a growing trend where people put setup of variables into
> > pkg_setup that only matter to src_* funcs presumably so they don't have
> > to call the respective src_* func from an inherited eclass. 
> > unfortunately this adds pointless overhead to binpkgs.  can we please
> > move away from this practice ?
> 
> Every Xfce ebuild in gentoo-x86 is using pkg_setup() for 3 variables,
> DOCS for src_install, PATCHES for src_prepare

these are static variables, so defining them in a func is pointless

> and XFCONF for src_configure

now you're down to one variable which means you've got one func to /properly/ 
define
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to