On Sat, Aug 04, 2012 at 02:22:52PM -0500, Doug Goldstein wrote:
> On Sat, Aug 4, 2012 at 2:31 AM, Samuli Suominen <ssuomi...@gentoo.org> wrote:
> > If you don't use double [[ then ${ROOT} will need "" quoting
> >
> 
> Don't do top post code reviews. Snip out the context and do code
> reviews inline so that your feedback is meaningful. Top posting and
> leaving the entire commit with CVS metadata and all is just wasteful
> and silly.

This has been fixed.

WRT Doug's request, the important part is "snip out the context". Don't
just insert comments and leave the entire commit in the message.

Thanks,

William

Attachment: pgpe5r4vFZV7T.pgp
Description: PGP signature

Reply via email to