On Tue, 7 Aug 2012 18:03:14 +0200 Torsten Veller <t...@gentoo.org> wrote:
> * "Fabian Groffen (grobian)" <grob...@gentoo.org>: > > grobian 12/08/07 15:21:54 > > > > Modified: ChangeLog > > Added: XML-Parser-2.410.0-r1.ebuild > > Log: > > Fix expat detection for FreeBSD that silently went unnoticed. > > The following single quotes were dropped: > > -myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)' > EXPATINCPATH='${EPREFIX}/usr/include'" > +myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir) > EXPATINCPATH=${EPREFIX}/usr/include" > > Sorry, I don't understand the problem. Is it a general problem with > the single quote or a special FreeBSD problem? A general problem. It won't work unless it's eval-ed. And if it were, there will be more harm than you can possibly imagine. > I think we should convert all myconf strings to arrays: > myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir) > EXPATINCPATH="${EPREFIX}"/usr/include ) +1. -- Best regards, Michał Górny
signature.asc
Description: PGP signature