-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 - -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
On 06/09/12 04:26 PM, Michał Górny wrote: Not sure; you think of so many different things.. :D I wanted it to be short -- this is a convenience variable to be used in *DEPEND; and since it contains Python Target Use Dependencies, i figured the acronym was the best way to go.. PS, '@INTERNAL' is probably not a good tag to set here but i couldn't find documentation on what tags were available; if there's a @READONLY or @CONSTANT that would be best. The 'for impl in ${PYTHON_COMPAT}' loop is actually run in global scope later, to set *DEPEND on each python implementation; i haven't checked but it's possible it can be done there. Also, other bits are already using temp variables in global scope. Also2, since this var needs to be substituted directly into atoms of the ebuild's *DEPEND, imo it needs to be in global scope as well Could be, yes. I had thought to set it before the check as PYTHON_COMPAT itself is assigned (if unset) before the check. - -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iF4EAREIAAYFAlBJCTUACgkQ2ugaI38ACPD3TwEAj1rtDO1Rpbmf0g+nU+oHTj5Y HIFVsn+bzbx+CB1xU5QBAKxXx5p33y4dhk03zM1VjRWM5J9QdC/uDGq42yapnfdd =hm2B - -----END PGP SIGNATURE----- -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iF4EAREIAAYFAlBJCrMACgkQ2ugaI38ACPAZjwD+PsGxG64rhKM5vmSO+g9Gc1Ij N62tR4dar4zGlIGwwfUA/0JH62LPRO/sv6BsvAHWRfXuuU4tkYotY2m7yx5LF6sH =Ff8b -----END PGP SIGNATURE-----