-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/25/2012 07:43 PM, Michał Górny wrote: > On Thu, 25 Oct 2012 18:41:47 +0200 hasufell <hasuf...@gentoo.org> > wrote: > >> 1. there is still no way to convert shebangs via python-r1 > > What conversion do you expect? The docs say it clearly that the > eclass will be extended on request, so please file a clear request > what you want with an example use case.
request: A function that converts the shebang to a version specific python shebang chosen by me. usecase: python scripts installed by a non-distutils build system which need appropriate shebang conversion (Unless we can fix that in a different way.) > >> 2. there are no equivalent functions to the python_get_* stuff >> which are sometimes necessary for broken build systems or test >> phases > > There is python_export(). I will be happy to extend it / add > python_get*() wrappers when someone makes a clear list of what is > needed. > > Example use cases will be appreciated again. Good examples will > make it possible to choose good variable names. example: x11-misc/redshift-1.7-r1 I'll give more examples as I come across those again. This is much "afair". > >> 3. there is no equivalent for python_mod_optimize. Having that >> in distutils-r1 does not suffice for non-distutils packages where >> I might have to do that stuff manually. > > There is a lot of stuff missing for packages which try to install > Python stuff by hand rather than using proper setup. I will be > happy to provide more when I know what is actually needed and how > it will be used. > example: x11-misc/redshift-1.7-r1 Again, I'll give more examples as I come across those. >> 5. distutils-r1_rename_scripts does not allow to specify a >> location possibly breaking non-standard locations (e.g. games >> location) > > It's a quick function. Adding additional paths or changing the > algorithm won't be hard. Just don't expect me to do random stuff > just because someone may want that someday. > > FYI: I've added that mindless games/bin to the paths. that games/bin change is not sufficient since the games variables can be modified by the user and this is supported by the games eclass. So you have to pass an option to the ebuild developer. > >> 8. how would I manually generate implementation-suffixed scripts >> without distutils-r1? > > You would use the function I would introduce when I got the > request filed and potential discussion done. Most importantly, > whether there should be a way to call 2to3 on the scripts. > > By the way, did you just request two partial features instead of > requesting a way to manually install Python scripts? > >> example: x11-misc/redshift-1.7-r1 > > Thanks. I will take a look at that package and see what is > necessary to make it buildable with python-r1. > > By the way, do I understand correctly that right now you are > building stuff for a random Python implementation and removing it > afterwards? I believe that's something really worth fixing. > That way was chosen to avoid an extensive patch I have already written. The maintainer of the package did not want to keep that around through version bumps which is understandable. - ----- Currently you seem to have focused more on distutils when writing python-r1 which makes this eclass a bit raw. Waiting for other developers to file feature requests instead of figuring out those yourself before they even consider porting their ebuild to your new eclasses seems like a questionable policy to me. They might not be too excited about it to start discussions and feature requests just to switch from an already working implementation. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJQiYspAAoJEFpvPKfnPDWzP/UH/i3GYZjrN1J+p5XjLmB7a20F zYpZzjRSKJqv5V2xB3obngTEHT+qvSaQ4xMUdhrwuF/XpyEjD18z93kmzq1gPvan ofnek3WiTHxaB0AJ3RoOdYB8gPRXFZpWxtySDOFgrP322mY+sBNyHMLVQ4CIJwq5 UsRwSlJNM4yddKSmnTxdRt8unmNm9mhYcmWGtebJ7MDU1720RR/RP4TxtumvdP3y i4EDM61+kdoyKiXIfCIkKknj4CztiPZlyrRiGTFZ63+99mbJJt0qYCPYYzf9l+MV nCrM+zUjqGvmvMeLhMulpxbn2SW7E8PpJobwTiTR8I99voTCcHH3M9NFUhfWrbs= =//Y7 -----END PGP SIGNATURE-----
