On Sunday 25 November 2012 11:47:42 Justin wrote:
> # Copyright 1999-20012 Gentoo Foundation

it is not yet 20012

also, this file too has whitespace damage (indenting with spaces)

> [[ "${CUDA_VERBOSE}" == true ]] && NVCCFLAGS+=" -v"

wouldn't this be better done in cuda_sanitize ?

>     local _gcc_bindir _ver _args="" _flag _ret

they're local vars, so you don't need to use _ prefixes

> if [[ ! $(type -P cuda-config) ]]; then

it's more common to do something like:
        if cuda-config --help >/dev/null ; then

or, you could even inline it with the existing code:

        if ! args=$(cuda-config -s); then
                ... eerror/die ...
        else
                args=$(version_sort ${args})
                ...

>        if [[ ! -n ${_args} ]]; then

use "-z", not "! -n"
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to