-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 17/01/13 11:00 AM, Pacho Ramos wrote:
> 
> Another try ;)
> 


There doesn't seem to be any logic here to check if the README.gentoo
that was previously installed has differed from the one that will be
installed (if they differ then the changes should be shown, no?)

I think logic similar to the following could be added to ensure this
occurs, though:

readme.gentoo_check_update() {
  if [[ "${REPLACING_VERSIONS}" ]] ; then
    if diff -q "${T}"/README.gentoo \
    "${EROOT}/usr/share/doc/${PF}"/README.gentoo &>/dev/null; then
      touch "${T}"/README.gentoo.show
    fi
  else
    touch "${T}"/README.gentoo.show
  fi
}

readme.gentoo_pkg_preinst() {
        debug-print-function ${FUNCNAME} "${@}"
        readme.gentoo_check_update
}

Then, export the pkg_preinst phase too, and and in
readme.gentoo_print_elog , swap the conditional
"! [[ ${REPLACING_VERSIONS} ]]" with "[[ -e ${T}/README.gentoo.show ]]"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iF0EAREIAAYFAlD4LKoACgkQ2ugaI38ACPCRvwD/Ub4EBc4ypYgfSItCSXc+ma2C
nrNUySPoHE0Him8vwZkA+LXvVUCNYpwD+DRh/Q5wl5Le8yiDql5F3BuUN0EQU9g=
=JbM2
-----END PGP SIGNATURE-----

Reply via email to