Dnia 2014-07-02, o godz. 07:24:09
Ulrich Mueller <u...@gentoo.org> napisał(a):

> >>>>> On Tue, 01 Jul 2014, Ian Stakenvicius wrote:
> 
> > On 01/07/14 06:44 PM, Ciaran McCreesh wrote:
> >>> || ( amd64? (
> >> 
> >> I thought we were trying to discourage that abomination...
> 
> > It's still necessary, unfortunately, until such time as everything
> > in the tree no longer needs/depends on the emul-* packages (see news
> > item #8 for progress). Otherwise, end-users would end up with
> > dependency collisions.
> 
> Sure, the second block is needed, but the point is that foo? ( )
> conditionals inside a || ( ) group should be avoided.
> 
> I wonder if the dependency couldn't be written like this, without the
> amd64? () conditional:
> 
>     || (
>         (
>             >=dev-libs/glib-2.34.3:2[abi_x86_32(-)]
>             >=virtual/opengl-7.0-r1[abi_x86_32(-)]
>         )
>         (
>             app-emulation/emul-linux-x86-baselibs[-abi_x86_32(-)]
>             app-emulation/emul-linux-x86-opengl[-abi_x86_32(-)]
>         )
>     )
> 
> emul-linux-x86-* doesn't have keywords other than amd64, so it won't
> match on non-amd64 anyway.

It would but I wanted to be on the safe side when one of the developers
broke deps. I really don't want autounmask to try to keyword
emul-linux-x86 on x86 :). But maybe '-*' in the ebuild is enough.

As a note, something like this won't work properly because of
portage's broken dep resolver:

  || (
    dev-libs/foo[abi_x86_32(-)]
    dev-libs/foo[abi_ppc_32(-)]
  )

-- 
Best regards,
Michał Górny

Attachment: signature.asc
Description: PGP signature

Reply via email to