On 20 February 2015 at 04:06, Jeroen Roovers <j...@gentoo.org> wrote: > On Wed, 18 Feb 2015 19:58:29 +0800 > Ben de Groot <yng...@gentoo.org> wrote: > >> The attached patch proposes two helper functions to be added to >> qmake-utils.eclass. These functions echo the correct directory where >> qt binaries such as moc and lrelease are located. They can be used in >> ebuilds when such binaries need to be called directly. (Ebuilds should >> not rely on qtchooser for this.) >> >> Please review before I commit. > > Looks good (barring what Davide noted). > > Do you have a list of ebuilds that might benefit? > > I know net-analyzer/wireshark might, but it doesn't even use > qmake-utils.eclass right now simply because it doesn't use qmake (but it > does use moc and uic, so I wouldn't expect to find those functions in an > eclass seemingly about qmake). >
Committed, with improvements by Davide. Based on a quick qgrep for lrelease/moc/uic, packages that would benefit are: app-cdr/qpxtool app-crypt/pinentry app-editors/znotes app-text/diffpdf app-text/qpdfview dev-util/universalindentgui games-board/qgo games-emulation/higan games-kids/cubetest games-util/higan-purify media-sound/lastfmplayer media-sound/musescore media-video/smplayer media-video/videocut media-video/vlc media-video/xvideoservicethief net-analyzer/wireshark net-im/psi net-im/skype net-p2p/transmission sci-calculators/speedcrunch sci-geosciences/gpsbabel sci-geosciences/merkaartor sci-visualization/qtiplot/ sys-boot/unetbootin -- Cheers, Ben | yngwin Gentoo developer