On 05 Jun 2015 09:34, William Hubbs wrote: > On Fri, Jun 05, 2015 at 12:54:45AM -0400, Mike Frysinger wrote: > > On 04 Jun 2015 14:10, William Hubbs wrote: > > > # @MAINTAINER: > > > # William Hubbs <willi...@gentoo.org> > > > # @BLURB: Eclass for fetching and unpacking go repositories. > > > # @DESCRIPTION: > > > # This eclass is written to ease the maintenance of live ebuilds > > > # of software written in the Go programming language. > > > > this should note the ebuild is responsible for depending on the right vcs > > packages. e.g. if you use git, then you need to depend on git. > > Since "go get" fetches $EGO_PN and its dependencies, there is no way an > ebuild author could get this right without reading all of the import > statements in the source for their package and all of its dependencies. > I don't really want to ask ebuild authors to keep up with all of that.
i'm aware. my point is that with some sites, you know they're going to be
using
*at least* one vcs. if they're pointing to github, that will be git. if the
project ends up only pulling from git, then you've automatically made it work
for them.
if they need additional vcs's, then they can simply depend on it directly. we
don't need to be perfect here, and if we can cover the majority of cases, i
think it's worth the effort.
> > > if [[ ${EVCS_OFFLINE} ]]; then
> > > export GOPATH="${S}:${GOPATH}"
> >
> > what if GOPATH isn't set ? should this always be appending a colon ?
>
> I thought it would always be set at this point because it was initially
> set to ${EGO_STORE_DIR} in the env_setup function. What I can do, if it
> makes things more clear, is to replace the value of GOPATH instead of
> prepending it.
you're right, i forgot about that line. it should be fine. it'll clobber
GOPATH that the user has, but we probably want that anyways right ?
-mike
signature.asc
Description: Digital signature
