Dnia 2015-08-07, o godz. 21:42:59
Ulrich Mueller <u...@gentoo.org> napisał(a):

> >>>>> On Fri, 7 Aug 2015, Michał Górny wrote:
> 
> > The function can return one of the following return codes:
> 
> > - 0 -- indicating that the package should be rebuilt from ebuild
> >   (changes occured),
> 
> > - 1 -- indicating that the package needs not be rebuilt.
> 
> > The function must use 'die' if an error preventing the function
> > from determining the state occurs.
> 
> Wouldn't it be feasible to leave error handling in that case to the
> caller, i.e. have a third return code for the case there is some
> failure?
> https://bugs.gentoo.org/show_bug.cgi?id=482666#c2

What for? We need to support 'die' anyway, I don't see a reason to have
two different variants of error reporting and magical exit codes.

> > The function can output any user-oriented messages. The following
> > output functions are made available: einfo, einfon, elog, ewarn,
> > eerror, ebegin, eend. The following additional functions are
> > available: die, assert, has, hasv, hasq.
> 
> No use/usev/usex functions? There might be cases where a rebuild is
> only needed for a certain combination of USE flags.

I'd rather not implement all that in smart-live-rebuild. Maybe it'd
make sense to have that in PM-implemented check in EAPI 7.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

Attachment: pgpYb2OcsQSPP.pgp
Description: OpenPGP digital signature

Reply via email to