On Tue, Jan 26, 2016 at 1:50 PM, Michał Górny <mgo...@gentoo.org> wrote: > Dnia 26 stycznia 2016 13:36:00 CET, Davide Pesavento <p...@gentoo.org> > napisał(a): >>On Mon, Jan 25, 2016 at 9:29 PM, Justin Lecher <j...@gentoo.org> wrote: >>> Signed-off-by: Justin Lecher <j...@gentoo.org> >>> --- >>> eclass/cmake-utils.eclass | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass >>> index 01de9a5..23339ab 100644 >>> --- a/eclass/cmake-utils.eclass >>> +++ b/eclass/cmake-utils.eclass >>> @@ -112,7 +112,7 @@ _CMAKE_UTILS_ECLASS=1 >>> # for econf and is needed to pass TRY_RUN results when >>cross-compiling. >>> # Should be set by user in a per-package basis in >>/etc/portage/package.env. >>> >>> -case ${EAPI} in >>> +case ${EAPI:-0} in >>> 2|3|4|5|6) : ;; >>> *) die "EAPI=${EAPI:-0} is not supported" ;; >>> esac >>> -- >>> 2.7.0 >>> >> >>Why? > > Indeed, why? I think it would be cleaner to simply quote the parameter to > case. >
AFAIK even quoting would be unnecessary in this context (assuming bash).