Matt Turner schrieb:
This sounds good in theory, but I think it's pretty well established that in practice this isn't effective and instead is a large waste of time.
I think even the thread starter stated that -Werror is unnecessary in the vast majority of cases.
In fact, the foundational premise that it's possible to build without warnings everywhere is simply wrong. Consider again the bug that started this. The maintainer had not built this configuration. None of the arch teams had built this configuration until I did for the last architecture Cc'd. The patch committed doesn't change anything installed on the system, if not for Werror preventing the code from building.
It is indeed an insurmountable task to write code that is warning-free from the beginning across architectures, compiler versions, etc. But that is not the goal anyway. It is examining the situation and taking appropriate action, and then applying a change to no longer cause that particular warning (or make it non-fatal if the warning is bogus/harmless).
Best regards, Chí-Thanh Christopher Nguyễn
