On Wed, Sep 12, 2018 at 6:55 PM Thomas Deutschmann <whi...@gentoo.org> wrote: > > On 2018-09-12 16:50, Rich Freeman wrote: > > There is also the case where we want these warnings to block > > installation, because the risk of there being a problem is too great. > > I really disagree with that. So many devs have already said multiple > times in this thread that "-Werror" is only turning existing warnings > into fatal errors but "-Werror" itself doesn't add any new checks and > more often requires "-O3" to be useful. >
This seems unlikely. If upstream is using -Werror in their build system, then they'd be getting build errors if these warnings already existed at the time they released the version. Now, I could buy that -Werror turns NEW warnings into fatal errors, due to the use of a newer toolchain, since upstream probably didn't test with that toolchain and thus wouldn't have seen the warning. If the warning only appears with -O3, and the package isn't built with -O3, then -Werror is a no-op and is harmless. But, I think there is somewhat of a legitimate point in pointing out that -Werror is in some sense just a proxy for detecting when a toolchain is being used which wasn't tested by upstream. You could accomplish the same by sticking a ton of toolchain blockers in the package. Of course, I can't imagine the toolchain team would be terribly happy about that, but if you want to avoid using newer toolchains with older versions of a package that would probably the the appropriate way to do it. -- Rich
