On Wed, 2019-05-29 at 11:00 +0200, Michael Haubenwallner wrote:
> ---
>  eclass/darcs.eclass | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/eclass/darcs.eclass b/eclass/darcs.eclass
> index 489008a87f1..81003651680 100644
> --- a/eclass/darcs.eclass
> +++ b/eclass/darcs.eclass
> @@ -85,8 +85,16 @@ SRC_URI=""
>  
>  # --- end ebuild-configurable settings ---
>  
> -DEPEND="dev-vcs/darcs
> -     net-misc/rsync"
> +case ${EAPI:-0} in
> +     [0-6]*)

Why the *? Do we really care about EAPI="5-HDEPEND" and others?

> +             DEPEND="dev-vcs/darcs
> +                     net-misc/rsync"
> +             ;;
> +     *)
> +             BDEPEND="dev-vcs/darcs
> +                     net-misc/rsync"
> +             ;;
> +esac
>  
>  # @FUNCTION: darcs_patchcount
>  # @DESCRIPTION:

Might be worth thinking about adding an EAPI whitelist like we do for
other eclasses. Just an idea, not required.


Reply via email to