Re: [gentoo-dev] [PATCH] fcaps.eclass: disable fcaps() on Prefix.

[Fabian Groffen]

On 08-03-2020 15:26:50 +0800, hero...@gentoo.org wrote:
> From: Benda Xu <hero...@gentoo.org>
> 
> Gentoo Prefix runs with a normal user and cannot grant extra
> capabilities.  Exit gracefully with a message.
> 
> Signed-off-by: Benda Xu <hero...@gentoo.org>
> ---
>  eclass/fcaps.eclass | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/eclass/fcaps.eclass b/eclass/fcaps.eclass
> index 467f955f5e9a..563d177c92d5 100644
> --- a/eclass/fcaps.eclass
> +++ b/eclass/fcaps.eclass
> @@ -78,6 +78,11 @@ DEPEND="filecaps? ( sys-libs/libcap )"
>  fcaps() {
>       debug-print-function ${FUNCNAME} "$@"
>  
> +     if [[ ${EUID} != 0 ]] ; then
> +             einfo "Insufficient privileges to execute ${FUNCNAME[0]}"
> +             return 0

Perhaps add "ignoring" or something in the message here to make it clear
this isn't treated as an error?

Thanks,
Fabian

> +     fi
> +
>       # Process the user options first.
>       local owner='root'
>       local group='0'
> -- 
> 2.25.0
> 
> 

-- 
Fabian Groffen
Gentoo on a different level

signature.asc
Description: PGP signature