> On 31 Mar 2021, at 10:09, Ulrich Mueller <u...@gentoo.org> wrote:
> 
>>>>>> On Wed, 31 Mar 2021, Andreas Sturmlechner wrote:
> 
>> setup-allowed-flags() {
>> +    [[ ${EAPI} == [0-7] ]] ||
>> +            die "Internal function ${FUNCNAME} is not available in 
>> >=EAPI-8."
>> +    _setup-allowed-flags
>> +}
> 
> Strictly speaking, EAPIs are strings, so numeric comparison is not
> meaningful. Suggestion: "... is not available in EAPI ${EAPI}."

That’s a reason to not do arithmetic comparison in e.g. Bash, but >= refers
to age/chronological order here, which isn’t a problem.

> 
>> test-flag-PROG() {
>> +    [[ ${EAPI} == [0-7] ]] ||
>> +            die "Internal function ${FUNCNAME} is not available in 
>> >=EAPI-8."
>> +    _test-flag-PROG
>> +}
> 
>> test-flags-PROG() {
>> +    [[ ${EAPI} == [0-7] ]] ||
>> +            die "Internal function ${FUNCNAME} is not available in 
>> >=EAPI-8."
>> +    _test-flags-PROG
>> +}
> 
> Same for these.
> 
> Ulrich

Attachment: signature.asc
Description: Message signed with OpenPGP

Reply via email to