On Mon, Jul 11, 2022 at 1:17 PM Ionen Wolkens <io...@gentoo.org> wrote:
>
> On Mon, Jul 11, 2022 at 01:08:52PM -0400, Mike Gilbert wrote:
> > On Mon, Jul 11, 2022 at 12:56 PM Ulrich Mueller <u...@gentoo.org> wrote:
> > >
> > > >>>>> On Mon, 11 Jul 2022, Ionen Wolkens wrote:
> > > >> - ebegin " python_check_deps"
> > > >> - python_check_deps
> > > >> - eend ${?}
> > > >> + einfo " python_check_deps"
> > > >> + if python_check_deps; then
> > > >> + einfo " python_check_deps succeeded"
> > > >> + else
> > > >> + einfo " python_check_deps failed"
> > > >> + fi
> > > >> }
> > >
> > > > I was about to go about merging this as suggested, but this masks the
> > > > return value, and then things like this always succeed:
> > >
> > > > if _python_run_check_deps "${impl}"; then
> > >
> > > Maybe leave ebegin/eend in place then, which was invented precisely for
> > > this use case? What's so bad about nesting it?
> >
> > It leads to odd looking output.
> >
> > https://gitweb.gentoo.org/proj/portage.git/commit/?id=eba088af8f335c0adb386461e6df1267e24800e7
> >
>
> Isn't that a portage problem? I don't think stopping legitimate use
> because portage displays messages weird is the right thing to do but
> should rather improve how portage displays them in this situation.
What is a "good" way to display it? I don't really think you can make
ebegin/eend look good when there are lines of output between them.
