On Tue, 2022-09-13 at 10:36 -0400, Matt Turner wrote:
> On Tue, Sep 13, 2022 at 2:38 AM Michał Górny <mgo...@gentoo.org> wrote:
> > 
> > On Mon, 2022-09-12 at 20:58 -0400, Matt Turner wrote:
> > > Signed-off-by: Matt Turner <matts...@gentoo.org>
> > > ---
> > >  metadata.xsd | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/metadata.xsd b/metadata.xsd
> > > index 87972cb..cced33d 100644
> > > --- a/metadata.xsd
> > > +++ b/metadata.xsd
> > > @@ -279,6 +279,7 @@
> > >                       <xs:enumeration value='gentoo'/>
> > >                       <xs:enumeration value='github'/>
> > >                       <xs:enumeration value='gitlab'/>
> > > +                     <xs:enumeration value='gnome'/>
> > >                       <xs:enumeration value='google-code'/>
> > >                       <xs:enumeration value='hackage'/>
> > >                       <xs:enumeration value='heptapod'/>
> > 
> > Some examples, please.  Are these somehow "global" identifiers or
> > specific to their GitLab instances?
> 
> This would be for gitlab.gnome.org. E.g. for x11-terms/gnome-terminal
> whose git repo is located at
> https://gitlab.gnome.org/GNOME/gnome-terminal.git, we'd have
> 
> <remote-id type="gnome">GNOME/gnome-terminal</remote-id>
> 
> Similar situation for 'freedesktop' in patch 2/2, for gitlab.freedesktop.org.
> 

Well, then I guess I'd prefer if these were "gnome-gitlab"
and "freedesktop-gitlab" to make it clear which services the names
correspond to.

-- 
Best regards,
Michał Górny


Reply via email to