[gentoo-dev] [PATCH 50/61] toolchain-funcs.eclass: Quote argument of ":" command

[Ulrich Müller]

This avoids globbing, see: https://www.shellcheck.net/wiki/SC2223

Signed-off-by: Ulrich Müller <u...@gentoo.org>
---
 eclass/toolchain-funcs.eclass | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/eclass/toolchain-funcs.eclass b/eclass/toolchain-funcs.eclass
index 805a3b0dfe61..63db0cfa5e0e 100644
--- a/eclass/toolchain-funcs.eclass
+++ b/eclass/toolchain-funcs.eclass
@@ -355,16 +355,16 @@ tc-export_build_env() {
                # Some build envs will initialize vars like:
                # : ${BUILD_LDFLAGS:-${LDFLAGS}}
                # So make sure all variables are non-empty. #526734
-               : ${BUILD_CFLAGS:=-O1 -pipe}
-               : ${BUILD_CXXFLAGS:=-O1 -pipe}
-               : ${BUILD_CPPFLAGS:= }
-               : ${BUILD_LDFLAGS:= }
+               : "${BUILD_CFLAGS:=-O1 -pipe}"
+               : "${BUILD_CXXFLAGS:=-O1 -pipe}"
+               : "${BUILD_CPPFLAGS:= }"
+               : "${BUILD_LDFLAGS:= }"
        else
                # https://bugs.gentoo.org/654424
-               : ${BUILD_CFLAGS:=${CFLAGS}}
-               : ${BUILD_CXXFLAGS:=${CXXFLAGS}}
-               : ${BUILD_CPPFLAGS:=${CPPFLAGS}}
-               : ${BUILD_LDFLAGS:=${LDFLAGS}}
+               : "${BUILD_CFLAGS:=${CFLAGS}}"
+               : "${BUILD_CXXFLAGS:=${CXXFLAGS}}"
+               : "${BUILD_CPPFLAGS:=${CPPFLAGS}}"
+               : "${BUILD_LDFLAGS:=${LDFLAGS}}"
        fi
        export BUILD_{C,CXX,CPP,LD}FLAGS
 
@@ -654,7 +654,7 @@ tc-has-tls() {
                -l) ;;
                -*) die "Usage: tc-has-tls [-c|-l] [toolchain prefix]";;
        esac
-       : ${flags:=-fPIC -shared -Wl,-z,defs}
+       : "${flags:=-fPIC -shared -Wl,-z,defs}"
        [[ $1 == -* ]] && shift
        $(tc-getCC "$@") ${flags} "${base}.c" -o "${base}" >&/dev/null
        local ret=$?
-- 
2.40.0