[gentoo-dev] Re: [PATCH v2 2/3] add UNPACKER_NO_BANNER variable

[Florian Schmaus]

On 09/01/2024 09.39, Florian Schmaus wrote:

Signed-off-by: Florian Schmaus <f...@gentoo.org>
---
  eclass/0000-cover-letter.patch              |  49 ++++
  eclass/0001-greadme.eclass-new-eclass.patch | 305 ++++++++++++++++++++

Ignore those to patch files. They are accidentally added to the commit.

diff --git a/eclass/unpacker.eclass b/eclass/unpacker.eclass
index 2957ca02d3f4..73b763ca2018 100644
--- a/eclass/unpacker.eclass
+++ b/eclass/unpacker.eclass
@@ -42,6 +42,11 @@ inherit multiprocessing toolchain-funcs
  # `xz`, `plzip`, `pdlzip`, and `lzip`.  Make sure your choice accepts the 
"-dc" options.
  # Note: this is meant for users to set, not ebuilds.

+# @DEFAULT_UNSET
+# @DESCRIPTION:
+# If set, do not display the unpack banner with information what got unpacked 
where.
+
  # for internal use only (unpack_pdv and unpack_makeself)
  find_unpackable_file() {
        local src=$1
@@ -63,6 +68,8 @@ find_unpackable_file() {
  }

+       [[ ${UNPACKER_NO_BANNER} ]] && return
+
        echo ">>> Unpacking ${1##*/} to ${PWD}"
  }

+# @ECLASS_VARIABLE: UNPACKER_NO_BANNER unpack_banner() {

Also note that this only prevents the banner emitted by the unpacker.eclass. The eclass also invokes unpack() from PMS/portage, emitting a banner which can not be disabled via the eclass.

- Flow

OpenPGP_0x8CAC2A9678548E35.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature