[gentoo-dev] Re: [PATCH] efmtutil-sys: use ebegin/eend and log output

[Florian Schmaus]

I just noticed two things seconds after sending the patch:

Commit message is missing "texlive-common.eclass" prefix.

On 04/04/2024 15.01, Florian Schmaus wrote:

Use ebegin/eend and instead of redirecting the output to /dev/null
capture stdout and stderr under a file under $T.

Signed-off-by: Florian Schmaus <f...@gentoo.org>
---
  eclass/texlive-common.eclass | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/eclass/texlive-common.eclass b/eclass/texlive-common.eclass
index 66d3999bd103..0cc61f735cb2 100644
--- a/eclass/texlive-common.eclass
+++ b/eclass/texlive-common.eclass
@@ -199,9 +199,11 @@ etexmf-update() {
  efmtutil-sys() {
        if has_version 'app-text/texlive-core' ; then
                if [[ -z ${ROOT} && -x "${EPREFIX}"/usr/bin/fmtutil-sys ]] ; 
then
-                       einfo "Rebuilding formats"
-                       "${EPREFIX}"/usr/bin/fmtutil-sys --all &> /dev/null ||
-                               die -n "fmtutil-sys returned non-zero exit status 
${?}"
+                       ebegin "Rebuilding TexLive formats"
+                       "${EPREFIX}"/usr/bin/fmtutil-sys --all \
+                                               > "${T}"/fmutil-sys-all.log \
+                                               &> "${T}"/fmutil-sys-all.err.log

This should be 2> instead of &>

- Flow

OpenPGP_0x8CAC2A9678548E35.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature