On Thu, 2024-05-09 at 07:57 -0400, Michael Orlitzky wrote:
> The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to
> this commit, it was also marked "readonly", preventing it from being
> changed in an ebuild. In an overlay, and combined with the package
> naming restrictions in the PMS, this has the unfortunate side effect of
> prohibiting some otherwise-valid usernames. We drop the "readonly" to
> allow those users to be managed (in overlays) using GLEP81 packages.
>
> Signed-off-by: Michael Orlitzky <m...@gentoo.org>
> ---
> eclass/acct-user.eclass | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/eclass/acct-user.eclass b/eclass/acct-user.eclass
> index 66a4d6667888..a4fe5e9f5e34 100644
> --- a/eclass/acct-user.eclass
> +++ b/eclass/acct-user.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 2019-2023 Gentoo Authors
> +# Copyright 2019-2024 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
>
> # @ECLASS: acct-user.eclass
> @@ -58,12 +58,11 @@ inherit user-info
> # << Eclass variables >>
>
> # @ECLASS_VARIABLE: ACCT_USER_NAME
> -# @INTERNAL
> # @DESCRIPTION:
> # The name of the user. This is forced to ${PN} and the policy prohibits
> -# it from being changed.
> +# it from being changed. The variable is left writable for use in overlays;
> +# package naming restrictions would prohibit some otherwise-valid usernames.
You're not following the original style (double spaces).
> ACCT_USER_NAME=${PN}
> -readonly ACCT_USER_NAME
>
> # @ECLASS_VARIABLE: ACCT_USER_ID
> # @REQUIRED
--
Best regards,
Michał Górny
signature.asc
Description: This is a digitally signed message part
