On Mon, Oct 31, 2005 at 12:20:48AM -0500, Lina Pezzella wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Actually, I investigated those additional symbols on my linux box, > and it appears that they are undefined over there as well. The only > difference is that the linker on my linux box didn't care... The > package works perfectly fine with those symbols undefined, and if you > read the source, some of them are slated to be removed in future > versions anyways...
Ah... bleh... Bad source... > As for environ, it seems that is also entirely unnecessary for > graphviz Darwin. If you look at the Darwinports patch for > graphviz-2.6, they've simply removed the functionality to error on > that symbol being undefined. If you have a solution for this on a > large-scale, that'd be great, as I agree with you that it would be > more correct, and perhaps could solve other issues. For graphviz > though, it seems not to matter. This is what happens on Linux too in the end, if I get your message correctly. So it's fine with me. > In any case, I modified the Darwinports patch to be dependent on > host_os, so that we can patch the source unconditionally in the > ebuild. If you want to go the route of fixing the undefined symbol > for environ, please don't hesitate to change my patch. Let me know > what you decide so that I can contact upstream about the problem. Personally, I feel the patch is correct for us, but incorrect for submission to upstream. We simply ignore a problem with the patch, which seems to be ok, but we don't fix a problem. Upstream should fix the undefined symbols basically. So, I would not even think of submitting upstream, earlier tell them there are undefined symbols and that they should fix it :p. The solution for now is ok, and I trust you that it works. So thanks for your research on this thing. I guess we've learnt something again. (At least I did...). Would you please tell on the graphviz bug we (you) fixed it, if you haven't already? Of course ignore this if the latter is true. Thanks again. -- Fabian Groffen Gentoo for Mac OS X Project -- Interim Lead -- [email protected] mailing list
