Amit Dor-Shifer wrote:
> Still happens:

The attached patch applies on top of the other one. I tested it this
time and it seems to be all fixed now.

-- 
Thanks,
Zac
Index: bin/misc-functions.sh
===================================================================
--- bin/misc-functions.sh	(revision 14217)
+++ bin/misc-functions.sh	(revision 14218)
@@ -408,8 +408,8 @@
 
 	# Evaluate misc gcc warnings
 	if [[ -n ${PORTAGE_LOG_FILE} && -r ${PORTAGE_LOG_FILE} ]] ; then
-		# In debug mode, this variable definition will produce
-		# a false positive if it's shown in the trace.
+		# In debug mode, this variable definition and corresponding grep calls
+		# will produce false positives if they're shown in the trace.
 		local reset_debug=0
 		if [[ ${-/x/} != $- ]] ; then
 			set +x
@@ -424,7 +424,6 @@
 			": warning: comparisons like X<=Y<=Z do not have their mathematical meaning$"
 			": warning: null argument where non-null required "
 		)
-		[[ $reset_debug = 1 ]] && set -x
 		abort="no"
 		i=0
 		while [[ -n ${msgs[${i}]} ]] ; do
@@ -440,6 +439,7 @@
 				abort="yes"
 			fi
 		done
+		[[ $reset_debug = 1 ]] && set -x
 		f=$(cat "${PORTAGE_LOG_FILE}" | \
 			"$PORTAGE_BIN_PATH"/check-implicit-pointer-usage.py)
 		if [[ -n ${f} ]] ; then

Reply via email to