On Mon, Oct 03, 2011 at 02:48:55AM -0700, Zac Medico wrote: > On 10/02/2011 05:21 PM, Zac Medico wrote: > > On 10/02/2011 04:22 PM, Brian Harring wrote: > >> On Sun, Oct 02, 2011 at 02:10:09PM -0700, Zac Medico wrote: > > I've implemented it with booleans in this commit: > > > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=c8cd3a985cc529299411d7343a11004b7d1330ef > > > >> Should use a space delimited list instead named hashes instead; those > >> being the hashes that should be generated, and that can be /used/. > >> Not in the list, not an acceptable hash (even if a manifest2 carries > >> that data). > > > > Why? Boolean flags are simpler and they work. > > After some thought, I like the space delimited approach better. Here's > the patch, which retains the ability to remove the manifest hash > settings from layout.conf after they become redundant: > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d9d0606fe01618cc81fb0b862ada91149dad3746
Suggest you go through the implementation a bit closer; quick look, if the repo no longer uses what portage considers a required hash (atm, sha1), it still will force it in; while that's rather annoying for manifest creation, the validation logic there strikes me as probably being buggy for that case. ~harring
