On Wednesday 23 May 2012 15:21:51 Mike Frysinger wrote: > + self._inherit_re = re.compile(r'^\s*inherit\s(.*\s)?%s(\s|$)' %
in scanning the whole tree, this seems to cause some issues (not new) with
extended constructs and not detecting this ebuilds inherits an eclass
directly. some examples:
(1)
foo="autotools"
...
inherit ${foo}
this seems pointless imo since we've already ruled that multiple `inherit`
calls are OK
(2)
inherit ... \
autotools
this is annoying. maybe we should adapt the core line code to unroll these
before passing to the individual checks ?
(3)
[[ ${PV} == "9999" ]] && inherit autotools
this one would require tweaking the regex like so:
(^[[:space:]]*|[[:space:]])inherit
any opinions ?
-mike
signature.asc
Description: This is a digitally signed message part.
