On Sun, Jan 19, 2014 at 02:45:24PM -0800, Alec Warner wrote: > On Sun, Jan 19, 2014 at 2:44 PM, Alec Warner <anta...@gentoo.org> wrote: > > This function and the next function you wrote are identical. How > > about making a single function? > > > > … > > > > def getIntValueFromSettings(settings, key, default): > > … > > Note, don't actually use these function names, they are terrible.
A good name would be getint [1]. If we used ConfigParser, we wouldn't have to write any Portage-specific code at all ;). I don't think there's a shortage of things that could be streamlined here, and was trying to minimize rewriting until fetch() had been reduced to something I can comprehend ;). Cheers, Trevor [1]: http://docs.python.org/3/library/configparser.html#configparser.ConfigParser.getint -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
