On Monday 20 January 2014 19:50:54 Chris Reffett wrote:
> +             # Check for read-only filesystems

please use full sentences.  that means putting a period at the end.  this 
applies to many additions in this patch.

> +     try:
> +             with io.open("/proc/mounts", mode='r', 
encoding=_encodings['content'],
> +                     errors='replace') as f:
> +                             roregex = re.compile(r'(\A|,)ro(\Z|,)')
> +                             for line in f:
> +                                     if roregex.search(line.split(" 
> ")[3].strip()) is not 
None:
> +                                             romount = line.split(" 
> ")[1].strip()
> +                                             ro_filesystems.add(romount)

pretty sure the body of this with block is indented one too many times
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to