-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 20/02/14 01:08, Pavel Kazakov wrote: >> """Scan for failed merges fix them.""" > All the other modules put the second """ on a newline, so I wanted > to be consistent. Should I still make the change? What the other modules are doing is not necessarily an indication of what we should do. More often than not, they are the opposite of what we should do, and following them because "hey it might be terrible, but at least it's consistently terrible" isn't fruitful. So I agree with Alec.
If you want consistency, feel free to fix the other docstrings. ;-) >> 'module1' ? > All the other modules did it this way, so I wanted consistency. Same. >> What is this little guy? Can we just do this in a library >> someplace? > Checks if python version is greater than or equal to 3, but I > probably don't even need it since I'm not using longs. Arfrever has apparently inserted this kind of stuff a bunch of places. We should figure out a more systematic approach... Anyway, if you don't even need it, get rid of it. - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlMF39gACgkQRtClrXBQc7VSUgD/UpF2Yrb/R72yAv8e9jIV9gj4 GYS+XKL8vTqb3EZr6+AA+wV/D6VQHOA7fHpW/ijaxfY+LYfMpcDxXEgZZXvqoB7C =xrzm -----END PGP SIGNATURE-----
