On 12/07/2014 01:07 AM, Michał Górny wrote:
> Dnia 2014-12-07, o godz. 10:01:23
> Michał Górny <mgo...@gentoo.org> napisał(a):
> 
>> +                    if uid is not None
> 
> Missing ':' here, I won't resend the patch for it :P.
> 
>> +                            spawn_kwargs["uid"] = uid
>> +                            self.usersync_uid = uid
>> +                    if gid is not None:
>> +                            spawn_kwargs["gid"] = gid
>> +                            spawn_kwargs["groups"] = [gid]
>> +                    if home is not None:
>> +                            spawn_kwargs["env"]["HOME"] = home
>> +            elif ('usersync' in self.settings.features and
>>                      portage.data.secpass >= 2 and
>>                      (st.st_uid != os.getuid() and st.st_mode & 0o700 or
>>                      st.st_gid != os.getgid() and st.st_mode & 0o070)):
> 
> 
> 

LGTM.
-- 
Thanks,
Zac

Reply via email to