On 04/21/2015 10:27 AM, Zac Medico wrote: > On 04/21/2015 02:48 AM, Duncan wrote: >> Zac Medico posted on Mon, 20 Apr 2015 17:37:15 -0700 as excerpted: >> >>> On 04/20/2015 05:31 PM, Bertrand Jacquin wrote: >>>> On 21/04/2015 00:39, Zac Medico wrote: >>>>> These are in the master branch now: >>>>> >>>>> https://gitweb.gentoo.org/proj/portage.git/commit/? >> id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911 >>>>> >>>>> https://gitweb.gentoo.org/proj/portage.git/commit/? >> id=e74e2670e3f043608fced9847e54bdbb19f35169 >>>>> >>>> >>>> Thanks for that :) >>>> >>>>> I modified the test as follows in order to ensure that it still works >>>>> with shell globs: >>>>> >>>>> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo >>>>> "${root}"/${no_inst}) ]] ; then >>>> >>>> I do not really understand the use case here, do you have an example ? >>>> >>>> Cheers, >>>> >>> >>> Well, I don't use INSTALL_MASK myself, so I don't have a real-world >>> use-case for you. However, it's clear that the code will expand shell >>> globs, so I preserved that behavior for compatibility. >> >> I do, with shell globs, tho I didn't bother checking the above to see if >> they'd have been affected. >> >> The two install-masks with globs I use here are: >> >> *.la > > Since it doesn't have an absolute path, this glob is handled by the > find/rm code which comes just after the shell glob code that I was > talking about. > >> (Unmasked on libtool itself, since it has a *.la file that other >> package's .configure scripts test for.) >> >> /etc/cron.*/ >> >> (I use systemd's timers in place of cron and thus crontablets.) > > This is absolute, so it is handled by the shell glob code in question. >
Oh, I see what you mean now. It's reconciled by a temporary 'set -o noglob', followed by 'set +o noglob'. -- Thanks, Zac
